Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

[Greg T]

> On Oct. 13, 2012, 5:43 p.m., Greg T wrote:
> > I'm quite satisfied with the keyboard handling after applying your patch.
> > 
> > some notes:
> > - when I press key up/down at the top/bottom of a flippscroll view, the launcher jumps back to the favourite view. I think it should just stay in the current view.
> > - key_tab moves the keyboard focus around, away from the searchbar. Can you suppress that?
> 
> Richard Stockton wrote:
>     Note 1:
>       I first tried to keep the applicationView/flipScrollView visible (upon and Up/Down at the Top/Bottom of flipScrollView), but I kept creating nasty loops of focus between the SearchView and ApplicationsView. Different problems for the first column versus other columns... with and without a 3rd layer of children... and different for Left-To-Right and Right-To-Left tabs, too. 
>     
>     I can hack it as another usability bug, with this as Pre-Requisite. It would possibly involve changing appViewIsReceivingKeyEvents from bool to int, and letting it increment (with notReceiving behavior on even values, receiving behavior on odd values, and a new bool to detect and correct looping). Or, I could change the order of key event interpretation in the filter... again ... but that's dangerous.
>     
>     I'd like to get this done as-is first, because THIS problem is major. If you agree, then I'll open that new usability bug and assign to myself, still for 4.9 (2 weeks). We both agree that my new behavior is awkward, although it's (at least) quite clear that I've moved your View in a fundamental way.
>     
>     Note 2:
>       key_tab moves focus around in all instances of QAbstractItemView (which is the parent of all the contentArea views). This would constitute a change of behavior, and I'd also like to leave those other classes alone. (I'm not very good at this, I'd probably break it).
>

This is fine by me, since rev r8 is a fundamental improvement. Just address those 2 issues and we are good to go.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106789/#review20278
-----------------------------------------------------------


On Oct. 13, 2012, 4:19 a.m., Richard Stockton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106789/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2012, 4:19 a.m.)
> 
> 
> Review request for Plasma and Greg T.
> 
> 
> Description
> -------
> 
> Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2
> 
> 
> This addresses bug 307823.
>     http://bugs.kde.org/show_bug.cgi?id=307823
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/ui/flipscrollview.h bf12b9c 
>   plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 98bc0bd 
>   plasma/desktop/applets/kickoff/ui/launcher.h 0c3c5c8 
>   plasma/desktop/applets/kickoff/ui/launcher.cpp 3d85688 
>   plasma/desktop/applets/kickoff/ui/searchbar.cpp ab47302 
> 
> Diff: http://git.reviewboard.kde.org/r/106789/diff/
> 
> 
> Testing
> -------
> 
> Navigation of single-column Views, and execution of selected items.
> Navigation of "All Applicatons" flipScrollView, and execution of endpoint (child-less) items.
> 
> Return to "SearchBar" from within all Views. (Key_Up and Key_Down work in many situations, but not all situations of flipScrollView. Key_Tab always works, although it often needs to be pressed twice. Breadcrumb often receives focus after the first Key_Tab.)
> 
> Navigation and execution of selected items in all View "Tabs", after having returned focus to searchBar from within flipScrollView and other Views.
> 
> 
> Thanks,
> 
> Richard Stockton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121014/ce11425f/attachment.html>