Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

[Greg T]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106789/#review20278
-----------------------------------------------------------


I'm quite satisfied with the keyboard handling after applying your patch.

some notes:
- when I press key up/down at the top/bottom of a flippscroll view, the launcher jumps back to the favourite view. I think it should just stay in the current view.
- key_tab moves the keyboard focus around, away from the searchbar. Can you suppress that?


plasma/desktop/applets/kickoff/ui/flipscrollview.cpp
<http://git.reviewboard.kde.org/r/106789/#comment16031>

    this is already handled in moveCursor, isn't it?



plasma/desktop/applets/kickoff/ui/launcher.cpp
<http://git.reviewboard.kde.org/r/106789/#comment16030>

    Why did you split that up?


- Greg T


On Oct. 13, 2012, 4:19 a.m., Richard Stockton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106789/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2012, 4:19 a.m.)
> 
> 
> Review request for Plasma and Greg T.
> 
> 
> Description
> -------
> 
> Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2
> 
> 
> This addresses bug 307823.
>     http://bugs.kde.org/show_bug.cgi?id=307823
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/ui/flipscrollview.h bf12b9c 
>   plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 98bc0bd 
>   plasma/desktop/applets/kickoff/ui/launcher.h 0c3c5c8 
>   plasma/desktop/applets/kickoff/ui/launcher.cpp 3d85688 
>   plasma/desktop/applets/kickoff/ui/searchbar.cpp ab47302 
> 
> Diff: http://git.reviewboard.kde.org/r/106789/diff/
> 
> 
> Testing
> -------
> 
> Navigation of single-column Views, and execution of selected items.
> Navigation of "All Applicatons" flipScrollView, and execution of endpoint (child-less) items.
> 
> Return to "SearchBar" from within all Views. (Key_Up and Key_Down work in many situations, but not all situations of flipScrollView. Key_Tab always works, although it often needs to be pressed twice. Breadcrumb often receives focus after the first Key_Tab.)
> 
> Navigation and execution of selected items in all View "Tabs", after having returned focus to searchBar from within flipScrollView and other Views.
> 
> 
> Thanks,
> 
> Richard Stockton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121013/70be2057/attachment-0001.html>