Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

[Richard Stockton]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106789/
-----------------------------------------------------------

(Updated Oct. 12, 2012, 10:34 p.m.)


Review request for Plasma and Greg T.


Changes
-------

You can now "escape" from the ApplicationsView by pressing Key_Left, when in the LeftMost column of the Application Categories. You can "enter" ApplicationsView by pressing Key_Upm, with the view selected on the Tab Bar. Key Down has issues, which I can probably resolve quickly.


Description
-------

Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2


This addresses bug 307823.
    http://bugs.kde.org/show_bug.cgi?id=307823


Diffs (updated)
-----

  plasma/desktop/applets/kickoff/ui/flipscrollview.h bf12b9c 
  plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 98bc0bd 
  plasma/desktop/applets/kickoff/ui/launcher.h 0c3c5c8 
  plasma/desktop/applets/kickoff/ui/launcher.cpp 3d85688 
  plasma/desktop/applets/kickoff/ui/searchbar.cpp ab47302 

Diff: http://git.reviewboard.kde.org/r/106789/diff/


Testing
-------

Navigation of single-column Views, and execution of selected items.
Navigation of "All Applicatons" flipScrollView, and execution of endpoint (child-less) items.

Return to "SearchBar" from within all Views. (Key_Up and Key_Down work in many situations, but not all situations of flipScrollView. Key_Tab always works, although it often needs to be pressed twice. Breadcrumb often receives focus after the first Key_Tab.)

Navigation and execution of selected items in all View "Tabs", after having returned focus to searchBar from within flipScrollView and other Views.


Thanks,

Richard Stockton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121012/94a5b675/attachment.html>