Review Request: Fix padding to the left and right of text in a textField
David Edmundson
kde at davidedmundson.co.uk
Thu Oct 11 15:09:07 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106797/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
Fix padding to the left and right of text in a textField
Text was already fontSize*1.6 meaning there was a 0.3 textHeight padding on the top and bottom. Padding on the left and right was completely missing. It's fairly typical to make the padding on the top and bottom match left and right.
If this patch gets accepted I'll make the same change in TextArea.
Before and after shots show it best.
Diffs
-----
plasma/declarativeimports/plasmacomponents/qml/TextField.qml 201b61b958a04b621ccb20abbc5f1d7cfeea6798
Diff: http://git.reviewboard.kde.org/r/106797/diff/
Testing
-------
Screenshots
-----------
Before
http://git.reviewboard.kde.org/r/106797/s/766/
After
http://git.reviewboard.kde.org/r/106797/s/767/
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121011/711ec839/attachment.html>
More information about the Plasma-devel
mailing list