Review Request: Humble attempt to improve the ScreenSaver KCM

[Aleix Pol Gonzalez]

> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote:
> > just an idea: what about hiding the whole X screen saver stuff behind another configure dialog. Looking at the screenshot I find the design puts emphasis on the wrong part: what we want to remove takes more than 50 % of the available screen estate.
> 
> Marco Martin wrote:
>     another idea would be just show the screen saver part only when the screensaver radio is selected (i kept it a bit that way before merging btw, seemed a bit flashy..)

I agree. On the other hand, showing new dialogs it's considered bad practice. :/
Maybe we can show the xscreensaver part when it's enabled?

**Aleix turns the agateau-sign on** (see bat-signal for further reference)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106768/#review20087
-----------------------------------------------------------


On Oct. 8, 2012, 3:43 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106768/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 3:43 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Description
> -------
> 
> After complaining about this KCM last week, I wanted to give it a try to improve it a little. I think that the biggest stopper here is wanting to keep the screensaver here, because we've ended up with a 3-head monster:
> * simple locker
> * plasma-based locker
> * xscreensavers
> 
> Since it seems it's something we may want for the moment. IMHO, we should end up with the Plasma-based option alone. I just tried to re-organize it in a way I like a little better.
> 
> What I did
> - I aligned the locking labels to the left, like the Form Layout suggests. It creates a small puzzle, I'm unsure if that's a problem.
> - I added toolTips and whatsThis in the locking type option buttons, so that we can at least figure out what will happen when we lock.
> 
> 
> Diffs
> -----
> 
>   kcontrol/screensaver/screensaver.ui 6524e27 
>   kcontrol/screensaver/scrnsave.cpp 0125620 
> 
> Diff: http://git.reviewboard.kde.org/r/106768/diff/
> 
> 
> Testing
> -------
> 
> just messed with it for a while.
> 
> 
> Screenshots
> -----------
> 
> result
>   http://git.reviewboard.kde.org/r/106768/s/758/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121008/6054f95b/attachment-0001.html>