Review Request: Humble attempt to improve the ScreenSaver KCM

[Martin Gräßlin]

> On Oct. 8, 2012, 3:50 p.m., Jeremy Paul Whiting wrote:
> > That looks a bit better in my opinion.  I would change/fix the wording for the dashboard screen locker a bit "Click configure to find more about it!" doesn't sound quite right for a tooltip, maybe something like "Click the configure button to set it up" or something?
> 
> Marco Martin wrote:
>     maybe just "Configure the appearance of the screen locker"?
>     not sure neither an exclamation mark or an invitation to click the button feel right for a tooltip
>     
>     anyways, looks already better.
>     one thing, i think the two spinboxes should have the same width
> 
> Kai Uwe Broulik wrote:
>     Marco, is the Screenlocker also supposed to be themeable, ie. allow you to choose other themes (like you can in lightdm and other qml based stuff)?

@Kai Uwe: in future yes, the functionality is basically already available given that Plasma Active just uses a different QML file


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106768/#review20082
-----------------------------------------------------------


On Oct. 8, 2012, 3:43 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106768/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 3:43 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Description
> -------
> 
> After complaining about this KCM last week, I wanted to give it a try to improve it a little. I think that the biggest stopper here is wanting to keep the screensaver here, because we've ended up with a 3-head monster:
> * simple locker
> * plasma-based locker
> * xscreensavers
> 
> Since it seems it's something we may want for the moment. IMHO, we should end up with the Plasma-based option alone. I just tried to re-organize it in a way I like a little better.
> 
> What I did
> - I aligned the locking labels to the left, like the Form Layout suggests. It creates a small puzzle, I'm unsure if that's a problem.
> - I added toolTips and whatsThis in the locking type option buttons, so that we can at least figure out what will happen when we lock.
> 
> 
> Diffs
> -----
> 
>   kcontrol/screensaver/screensaver.ui 6524e27 
>   kcontrol/screensaver/scrnsave.cpp 0125620 
> 
> Diff: http://git.reviewboard.kde.org/r/106768/diff/
> 
> 
> Testing
> -------
> 
> just messed with it for a while.
> 
> 
> Screenshots
> -----------
> 
> result
>   http://git.reviewboard.kde.org/r/106768/s/758/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121008/6b463714/attachment.html>