Review Request: make color wallpaper thumbnail aspect ratio similar to primary screen aspect ratio

Reza Shah rshah0385 at kireihana.com
Mon Oct 8 09:54:41 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106754/
-----------------------------------------------------------

(Updated Oct. 8, 2012, 9:54 a.m.)


Review request for Plasma and Marco Martin.


Changes
-------

- changed m_size to QSize (seems working fine without QSizeF)
- removed kDebug for kephal size


Description
-------

I tried to make the behavior of the thumbnail to follow image wallpaper.
The thumbnail will have aspect ratio similar to active screen aspect ratio if possible.


Diffs (updated)
-----

  plasma/generic/wallpapers/color/CMakeLists.txt 5ad829d 
  plasma/generic/wallpapers/color/backgroundlistmodel.h 8bec6b4 
  plasma/generic/wallpapers/color/backgroundlistmodel.cpp 6fa4682 
  plasma/generic/wallpapers/color/color.cpp 05897ba 

Diff: http://git.reviewboard.kde.org/r/106754/diff/


Testing
-------

Tested using single monitor only but with different resolution.
I hope somebody with multi monitor setup can test this patch.


Thanks,

Reza Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121008/6eaaa1b2/attachment-0001.html>


More information about the Plasma-devel mailing list