Review Request: make color wallpaper thumbnail aspect ratio similar to primary screen aspect ratio

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106754/#review20035
-----------------------------------------------------------



plasma/generic/wallpapers/color/backgroundlistmodel.cpp
<http://git.reviewboard.kde.org/r/106754/#comment15868>

    why not scale m_size here?
    
    m_size.scale(BackgroundDelegate::SCREENSHOT_SIZE, BackgroundDelegate::SCREENSHOT_SIZE/1.6);
    
    vastly simplifies createPixmap below.



plasma/generic/wallpapers/color/backgroundlistmodel.cpp
<http://git.reviewboard.kde.org/r/106754/#comment15867>

    need to check that data() is valid before using it (the entire point of having a weak pointer :). i would do this at the beginning of the method in this case and return an empty pixmap in that case.


- Aaron J. Seigo


On Oct. 7, 2012, 11:33 a.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106754/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2012, 11:33 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> I tried to make the behavior of the thumbnail to follow image wallpaper.
> The thumbnail will have aspect ratio similar to active screen aspect ratio if possible.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/wallpapers/color/CMakeLists.txt 5ad829d 
>   plasma/generic/wallpapers/color/backgroundlistmodel.h 8bec6b4 
>   plasma/generic/wallpapers/color/backgroundlistmodel.cpp 6fa4682 
>   plasma/generic/wallpapers/color/color.cpp 05897ba 
> 
> Diff: http://git.reviewboard.kde.org/r/106754/diff/
> 
> 
> Testing
> -------
> 
> Tested using single monitor only but with different resolution.
> I hope somebody with multi monitor setup can test this patch.
> 
> 
> Thanks,
> 
> Reza Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121007/61f99b67/attachment.html>