Review Request: plasma-desktop: restore toolbox position

Commit Hook null at kde.org
Sat Oct 6 07:31:59 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106743/#review19995
-----------------------------------------------------------


This review has been submitted with commit 88d7dc41d845a512362b295a98e8e64510981a3d by Gregor Tätzner to branch master.

- Commit Hook


On Oct. 5, 2012, 6:59 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106743/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2012, 6:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> this patch looks trivial, but I get the bad feeling that this change could cause regressions. What was the purpose of that early exit in the first place?
> 
> 
> This addresses bug 263947.
>     http://bugs.kde.org/show_bug.cgi?id=263947
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/toolboxes/internaltoolbox.cpp b62370e8a428087bb7671b60632e8fe458d1ee67 
> 
> Diff: http://git.reviewboard.kde.org/r/106743/diff/
> 
> 
> Testing
> -------
> 
> no issues noted
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121006/1627f48d/attachment.html>


More information about the Plasma-devel mailing list