Review Request: Add minimumWidth and minimumHeight properties to Plasma Button
Commit Hook
null at kde.org
Fri Oct 5 20:49:15 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106717/#review19984
-----------------------------------------------------------
This review has been submitted with commit a74717fc5c9fd04d133031478bb2b78128c57af4 by David Edmundson to branch master.
- Commit Hook
On Oct. 3, 2012, 10:01 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106717/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2012, 10:01 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Add minimumWidth and minimumHeight properties to Plasma Button
>
> Rationale:
> see mailing list threads "Button component width" and "Fit Grid elements in Item" on plasma-devel
>
>
> Diffs
> -----
>
> plasma/declarativeimports/plasmacomponents/qml/Button.qml 915ba66
>
> Diff: http://git.reviewboard.kde.org/r/106717/diff/
>
>
> Testing
> -------
>
> Edited Widget gallery to have "width: minimumWidth" on a button. It looked ok.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121005/13c9a02e/attachment-0001.html>
More information about the Plasma-devel
mailing list