Review Request: Block screen edge activation for fullscreen windows

Kai Uwe Broulik kde at privat.broulik.de
Thu Oct 4 21:34:38 UTC 2012



> On Oct. 4, 2012, 3:02 p.m., Martin Gräßlin wrote:
> > After thinking about it some more: I'm most likely not going to push this, but go for an atom solution as noted by Thomas.
> > 
> > That would probably also fix issues for non fullscreen applications which need to reserve an area of the screen. E.g. Yakuake or Plasma Panels.
> > 
> > I keep the review open for the case we don't have a solution till feature freeze ;-)
> 
> Philip Turmel wrote:
>     I'm still hoping to create a generic solution per Thomas' request, but spare time has not been plentiful.  I *am* a heavy user of screen edges with full-screen VMs and with KRDC, so a default "on" would be a regression for me.  I'm using one corner ==> present desktops in 4.9 as I haven't rebased my left/right solution from 4.8.
>     
>     If you do push it, please consider leaving the corners as configured.

I especially like that I can e.g. still Present Windows out of a virtual machine that runs fullscreen, without the need of pressing the ungrab mouse keystroke.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106722/#review19905
-----------------------------------------------------------


On Oct. 4, 2012, 1:02 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106722/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 1:02 p.m.)
> 
> 
> Review request for kwin, Plasma and Aurélien Gâteau.
> 
> 
> Description
> -------
> 
> Block screen edge activation for fullscreen windows
> 
> If the active client is a fullscreen window, the screenedges on the
> screen the window is on get's blocked for activation.
> 
> We have to assume that the window is managing the screenedge itself to
> offer there additional functionality (e.g. a panel) and KWin's screen
> edge functionality would conflict.
> 
> 
> Diffs
> -----
> 
>   kwin/screenedge.cpp a1507c3543877477e564bba368feaa31bc44655e 
> 
> Diff: http://git.reviewboard.kde.org/r/106722/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121004/ec16af5e/attachment.html>


More information about the Plasma-devel mailing list