Review Request: Block screen edge activation for fullscreen windows

[Thomas Lübking]

> On Oct. 4, 2012, 1:13 p.m., Thomas Lübking wrote:
> > Special case solution?
> > 
> > This will (by assumed behavior, didn't look into details) for quite sure trigger bug reports ("can't switch desktops", "present windows no longer works with fullscreen <browser_here>"), so here's a warning about that ;-)
> > 
> > If some client wants to ensure unobscured input it can grab the pointer, what would also work with other WMs then...
> 
> Martin Gräßlin wrote:
>     actually it's not a special case solution. Looking at it, I see:
>     * games which grab mouse
>     * applications which have additional UI hidden at the top
>     
>     From the apps I sometimes use in fullscreen, these are:
>     * Gwenview
>     * Okular
>     * Browsers
>     * VMs
>     * VNC Viewer
>     
>     So it's actually a quite common feature. In fact I do not know any application not doing it.
>     
>     Concerning the possible complaints: I cannot remember a bug report about games preventing present windows.
>     
>     But it's not a big deal to add a config option to it.

you do not want to drop out of an ego shooter and be dead when you return, so they grab the input.
this is different with other applications.

reg. the other apps, this does rather imply edges (so most of the time desktop switching, iff) and not the corners.

reg. the option, there's still bug #182987 and (was) #293011

imo the major aspect here is however, that kwin fixes a problem of those clients which will remain for other WMs

that way, we could also just introduce KDE_NETWM_OCCUPY_EDGE or so


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106722/#review19888
-----------------------------------------------------------


On Oct. 4, 2012, 1:02 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106722/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 1:02 p.m.)
> 
> 
> Review request for kwin, Plasma and Aurélien Gâteau.
> 
> 
> Description
> -------
> 
> Block screen edge activation for fullscreen windows
> 
> If the active client is a fullscreen window, the screenedges on the
> screen the window is on get's blocked for activation.
> 
> We have to assume that the window is managing the screenedge itself to
> offer there additional functionality (e.g. a panel) and KWin's screen
> edge functionality would conflict.
> 
> 
> Diffs
> -----
> 
>   kwin/screenedge.cpp a1507c3543877477e564bba368feaa31bc44655e 
> 
> Diff: http://git.reviewboard.kde.org/r/106722/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121004/c09a1d2b/attachment.html>