Review Request: plasma-netbook: add a settings action to the panel
Marco Martin
notmart at gmail.com
Thu Oct 4 13:48:44 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106723/#review19899
-----------------------------------------------------------
Ship it!
fine for me
plasma/netbook/containments/netpanel/panel.cpp
<http://git.reviewboard.kde.org/r/106723/#comment15797>
you can recycle the same qaction pointer here without any issue
- Marco Martin
On Oct. 4, 2012, 1:41 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106723/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2012, 1:41 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This context menu option does the same thing like the cashew in the bottom corner: it opens the shell settings. My initial plan was to just open the panel toolbox...but the current implementation doesn't really seem to allow that.
>
>
> Diffs
> -----
>
> plasma/netbook/containments/netpanel/panel.h 970bf3c0e60915f49dc7318a9789bf9cd0830b59
> plasma/netbook/containments/netpanel/panel.cpp a53eb5f642b5102719bf11329b1a5c5be1c13c99
> plasma/netbook/shell/plasmaapp.cpp 22c54b2ba9e746e85eb7c581ebee26e3ba63b459
>
> Diff: http://git.reviewboard.kde.org/r/106723/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg T
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121004/04dbf511/attachment-0001.html>
More information about the Plasma-devel
mailing list