Review Request: Activities support for Gwenview

[Aurélien Gâteau]

> On Oct. 4, 2012, 8:12 a.m., Aurélien Gâteau wrote:
> > With this new version we are back to one ResourceInstance per DocumentView, which makes sense to me, but could you then move the ResourceInstance back to DocumentViewPrivate instead of maintaining a QHash in DocumentViewContainer? Unless I am missing something (which is highly possible!) you should be able to implement the focus notification in DocumentView::setCurrent(bool).
> 
> Ivan Čukić wrote:
>     If it is in DocView, it will end up in the KPart as well, right?
>     
>     That would work for Gwenview, but would fail when some other application uses GV's kpart. That is why I moved it above - the shell needs to do the reporting, not the part.

Ah right, makes sense. Can you just add a comment near the declaration of the QHash explaining this? Once this is done, feel free to commit it. Thank you for this work!


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106687/#review19874
-----------------------------------------------------------


On Oct. 3, 2012, 5:03 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106687/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 5:03 p.m.)
> 
> 
> Review request for Gwenview and Plasma.
> 
> 
> Description
> -------
> 
> Gwenview reports the open/close document events to activity manager daemon.
> Side-effect - support for Share-Like-Connect applet.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a73e4d3 
>   app/CMakeLists.txt e039198 
>   app/viewmainpage.cpp 055cd2a 
> 
> Diff: http://git.reviewboard.kde.org/r/106687/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121004/a3f8986e/attachment.html>