Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

[Aurélien Gâteau]

> On Oct. 4, 2012, 1:27 a.m., Aleix Pol Gonzalez wrote:
> > plasma/declarativeimports/plasmacomponents/qml/Button.qml, line 104
> > <http://git.reviewboard.kde.org/r/106717/diff/1/?file=88339#file88339line104>
> >
> >     unneeded change :)

It is actually good practice to systematically use semi-colons at the end of your JavaScript lines.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106717/#review19870
-----------------------------------------------------------


On Oct. 3, 2012, 10:01 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106717/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 10:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add minimumWidth and minimumHeight properties to Plasma Button
> 
> Rationale:
> see mailing list threads "Button component width" and "Fit Grid elements in Item" on plasma-devel
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/Button.qml 915ba66 
> 
> Diff: http://git.reviewboard.kde.org/r/106717/diff/
> 
> 
> Testing
> -------
> 
> Edited Widget gallery to have "width: minimumWidth" on a button. It looked ok.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121004/f822a663/attachment-0001.html>