Review Request: Activities support for Gwenview

Ivan Čukić ivan.cukic at kde.org
Wed Oct 3 16:22:12 UTC 2012



> On Oct. 3, 2012, 3:50 p.m., Aurélien Gâteau wrote:
> > I think you need to also update the activity resource in ViewMainPagePrivate::setCurrentView(): when the user is comparing two images, Gwenview should report which of the two images is current.

Cool, just learned about a new Gwenview feature :)


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106687/#review19836
-----------------------------------------------------------


On Oct. 2, 2012, 10:26 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106687/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 10:26 p.m.)
> 
> 
> Review request for Gwenview and Plasma.
> 
> 
> Description
> -------
> 
> Gwenview reports the open/close document events to activity manager daemon.
> Side-effect - support for Share-Like-Connect applet.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a73e4d3 
>   app/CMakeLists.txt e039198 
>   app/viewmainpage.cpp 055cd2a 
> 
> Diff: http://git.reviewboard.kde.org/r/106687/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121003/87c7d2a5/attachment.html>


More information about the Plasma-devel mailing list