Review Request: Activities support for Gwenview
Ivan Čukić
ivan.cukic at kde.org
Tue Oct 2 22:26:15 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106687/
-----------------------------------------------------------
(Updated Oct. 2, 2012, 10:26 p.m.)
Review request for Gwenview and Plasma.
Changes
-------
The newest incarnation.
Instead of putting the patch as low as KPart, the ResourceInstance is now used by the application itself. And it is a bit neater for that.
Although this removes the feature that Konqueror was able to report the events when it loads an image in the Gwenview part, it also removes issues that Share-Like-Connect would have in that situation due to inability of the implementation to tell whether it is currently shown document.
Description
-------
Gwenview reports the open/close document events to activity manager daemon.
Side-effect - support for Share-Like-Connect applet.
Diffs (updated)
-----
CMakeLists.txt a73e4d3
app/CMakeLists.txt e039198
app/viewmainpage.cpp 055cd2a
Diff: http://git.reviewboard.kde.org/r/106687/diff/
Testing
-------
Yes
Thanks,
Ivan Čukić
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121002/81145960/attachment-0001.html>
More information about the Plasma-devel
mailing list