Review Request: add preview thumbnail at color wallpaper config dialog

[Aleix Pol Gonzalez]

> On Oct. 2, 2012, 2:20 p.m., Aleix Pol Gonzalez wrote:
> > plasma/generic/wallpapers/color/itemsview.h, line 1
> > <http://git.reviewboard.kde.org/r/106626/diff/2/?file=88122#file88122line1>
> >
> >     Shouldn't the ItemsView be in some kind of common place?
> >     
> >     I probably should be using it in Animated Wallpapers as well...
> 
> Marco Martin wrote:
>     that idea struck me as well, but then the question is where.
>     
>     places are libplasma, where i think is no-no (we should remove things like that as much as we can for plasma2) or plasmagenericshell, but i don't want wallpapers linking to it.
>     
>     if those views were already qml it would be massively easier
> 
> Aaron J. Seigo wrote:
>     i think it's a moot point right now. it is not optimal at all, but in future we'll just have QML wallpapers and then it's a non-issue: we can wrap this in a standard QML component and wallpapers that need further configuration can use it with a model.

I've just "forked" the BackgroundDelegate as well, for the animated wallpapers.

I agree that if we want to move forward to QML we'll eventually dump any of those abstractions, but we probably have 5 or 6 BackroundDelegates at the moment.

In any case, QML config dialogs won't be possible until we figure out the styling, I'm afraid...


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106626/#review19754
-----------------------------------------------------------


On Oct. 2, 2012, 11:48 a.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106626/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 11:48 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This is part of my feature plan for 4.10.
> 
> Added preview thumbnail at color wallpaper configuration dialog for each background mode, 
> and removed the background mode combobox. 
> 
> 
> Diffs
> -----
> 
>   plasma/generic/wallpapers/color/CMakeLists.txt 71006ee 
>   plasma/generic/wallpapers/color/backgrounddelegate.h e69de29 
>   plasma/generic/wallpapers/color/backgrounddelegate.cpp e69de29 
>   plasma/generic/wallpapers/color/backgroundlistmodel.h e69de29 
>   plasma/generic/wallpapers/color/backgroundlistmodel.cpp e69de29 
>   plasma/generic/wallpapers/color/color.h a477aa9 
>   plasma/generic/wallpapers/color/color.cpp d696c2d 
>   plasma/generic/wallpapers/color/config.ui d5bf809 
>   plasma/generic/wallpapers/color/itemsview.h e69de29 
>   plasma/generic/wallpapers/color/itemsview.cpp e69de29 
> 
> Diff: http://git.reviewboard.kde.org/r/106626/diff/
> 
> 
> Testing
> -------
> 
> tested against master, worked fine.
> 
> 
> Screenshots
> -----------
> 
> new config dialog
>   http://git.reviewboard.kde.org/r/106626/s/740/
> 
> 
> Thanks,
> 
> Reza Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121002/4be98bec/attachment-0001.html>