Review Request: add preview thumbnail at color wallpaper config dialog

Reza Shah rshah0385 at kireihana.com
Tue Oct 2 11:48:17 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106626/
-----------------------------------------------------------

(Updated Oct. 2, 2012, 11:48 a.m.)


Review request for Plasma and Marco Martin.


Changes
-------

- removed trailing spaces from init() inside color.h 
- added copyright line to color.h


Description
-------

This is part of my feature plan for 4.10.

Added preview thumbnail at color wallpaper configuration dialog for each background mode, 
and removed the background mode combobox. 


Diffs (updated)
-----

  plasma/generic/wallpapers/color/CMakeLists.txt 71006ee 
  plasma/generic/wallpapers/color/backgrounddelegate.h e69de29 
  plasma/generic/wallpapers/color/backgrounddelegate.cpp e69de29 
  plasma/generic/wallpapers/color/backgroundlistmodel.h e69de29 
  plasma/generic/wallpapers/color/backgroundlistmodel.cpp e69de29 
  plasma/generic/wallpapers/color/color.h a477aa9 
  plasma/generic/wallpapers/color/color.cpp d696c2d 
  plasma/generic/wallpapers/color/config.ui d5bf809 
  plasma/generic/wallpapers/color/itemsview.h e69de29 
  plasma/generic/wallpapers/color/itemsview.cpp e69de29 

Diff: http://git.reviewboard.kde.org/r/106626/diff/


Testing
-------

tested against master, worked fine.


Screenshots
-----------

new config dialog
  http://git.reviewboard.kde.org/r/106626/s/740/


Thanks,

Reza Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121002/cff73df2/attachment.html>


More information about the Plasma-devel mailing list