Review Request: load the images for the themes correctly

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106680/#review19718
-----------------------------------------------------------



editors/editpage.cpp
<http://git.reviewboard.kde.org/r/106680/#comment15693>

    and another case for a QHash. will be more performant (not critical in this particular case) and certainly save lots of repetative and error-prone code.



packagemodel.cpp
<http://git.reviewboard.kde.org/r/106680/#comment15691>

    this looks like a use case for QHash<QString, QStringList>



packagemodel.cpp
<http://git.reviewboard.kde.org/r/106680/#comment15692>

    here too :)


- Aaron J. Seigo


On Oct. 1, 2012, 8:20 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106680/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 8:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> create a new theme package->click on the new
> 
> a file dialog should appear but instead a simple edit box appears requesting a new filename.
> 
> This patch solves the issue
> 
> 
> Diffs
> -----
> 
>   editors/editpage.h 8cc5fab 
>   editors/editpage.cpp 91f6bce 
>   mainwindow.h 6ac6fcd 
>   mainwindow.cpp 8e87b7b 
>   packagemodel.cpp 67cc0f4 
> 
> Diff: http://git.reviewboard.kde.org/r/106680/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121001/ade15fe3/attachment-0001.html>