Review Request: adjust qml wallpaper setting dialog and make it's color button remember previous value

Aleix Pol Gonzalez aleixpol at gmail.com
Fri Nov 30 14:18:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107532/#review22819
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 30, 2012, 1:43 p.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107532/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 1:43 p.m.)
> 
> 
> Review request for Plasma and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> This patch adjust the layout of qmlwallpaper setting dialog for background color selection layout.
> The patch also make the color button to display previously selected color. 
> 
> 
> Diffs
> -----
> 
>   wallpapers/qmlwallpapers/viewconfig.ui d85cc9f 
>   wallpapers/qmlwallpapers/wallpapersqml.cpp 5152e99 
> 
> Diff: http://git.reviewboard.kde.org/r/107532/diff/
> 
> 
> Testing
> -------
> 
> tested against master, seems no problem
> 
> 
> Screenshots
> -----------
> 
> before after
>   http://git.reviewboard.kde.org/r/107532/s/861/
> 
> 
> Thanks,
> 
> Reza Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121130/d1c44904/attachment.html>


More information about the Plasma-devel mailing list