Review Request: load the images for the themes correctly

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106680/#review22754
-----------------------------------------------------------



plasmate/packagemodel.cpp
<http://git.reviewboard.kde.org/r/106680/#comment17386>

    unused?



plasmate/packagemodel.cpp
<http://git.reviewboard.kde.org/r/106680/#comment17385>

    why not add "images", "config" and "animations" to m_themeImageDialogOptions and rename it to m_dialogOptions



plasmate/packagemodel.cpp
<http://git.reviewboard.kde.org/r/106680/#comment17387>

    should not have anything in here specific to a given package type, in this case "Plasma/Theme".



plasmate/packagemodel.cpp
<http://git.reviewboard.kde.org/r/106680/#comment17388>

    "Plasma/Theme" should not appear in this file.


- Aaron J. Seigo


On Nov. 5, 2012, 5:51 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106680/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 5:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> create a new theme package->click on the new
> 
> a file dialog should appear but instead a simple edit box appears requesting a new filename.
> 
> This patch solves the issue
> 
> 
> Diffs
> -----
> 
>   plasmate/editors/editpage.h 5cb3ea6 
>   plasmate/editors/editpage.cpp 7e82ff2 
>   plasmate/packagemodel.h efa3001 
>   plasmate/packagemodel.cpp 9eb0914 
> 
> Diff: http://git.reviewboard.kde.org/r/106680/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121129/51813b52/attachment-0001.html>