Review Request: Set history size before reading history so that all history can be loaded

Aaron J. Seigo aseigo at kde.org
Thu Nov 29 10:35:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107499/#review22746
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Nov. 28, 2012, 1:34 a.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107499/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2012, 1:34 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The pastebin applet always only read at most 3 histories from file on startup since the history size is still the default value 3 when these histories are added. This patch set the maximum size before histories are added.
> 
> 
> Diffs
> -----
> 
>   applets/pastebin/pastebin.cpp 208e6a3 
> 
> Diff: http://git.reviewboard.kde.org/r/107499/diff/
> 
> 
> Testing
> -------
> 
> Compiled and installed.
> Set history size to > 3 and upload > 3 images/text files.
> Restart plasma and the history list is of the correct size.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121129/18d5120d/attachment.html>


More information about the Plasma-devel mailing list