Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

[Diego Casella]

> On Nov. 26, 2012, 8:53 p.m., Diego Casella wrote:
> > plasmate/CMakeLists.txt, line 102
> > <http://git.reviewboard.kde.org/r/107470/diff/1/?file=96184#file96184line102>
> >
> >     >>I'm wondering if we really need to add a kdepimutils dependency for a simple email validation... Thoughts about that?
> >     >Plasmate already depends on qgpgme++ library which is in kdepimlibs. Kdepimutils are also part of the kdepimlibs.
> >     Actually, I made Plasmate to depend on QGpgme _only_ , not the entire kdepimlibs, in order to avoid unnecessary library inclusion/linkage dependencies. In fact, it looks for package "QGpgme" using FindQGpgme.cmake and links against ${QGPGME_LIBRARIES}, instead of using FindKdepimLibs.cmake.
> >     
> >     Real case example: on my system (Kubuntu 12.10), the dependencies for installing libqgpgme1 are:
> >     $polentino: sudo apt-cache depends libqgpgme1 
> >     libqgpgme1
> >       Depends: libc6
> >       Depends: libgpgme++2
> >       Depends: libqtcore4
> >       Depends: libstdc++6
> >       Breaks: kdepimlibs5
> >       Replaces: kdepimlibs5
> >     
> >     
> >     while, for libkpimutils4:
> >     $polentino:  sudo apt-cache depends libkpimutils4 
> >     libkpimutils4
> >       Depends: libc6
> >       Depends: libkdecore5
> >       Depends: libkdeui5
> >       Depends: libkemoticons4
> >       Depends: libkmime4
> >       Depends: libqtcore4
> >       Depends: libqtgui4
> >       Depends: libstdc++6
> >       Breaks: kdepimlibs5
> >       Replaces: kdepimlibs5
> >     
> >     
> >

heck, forget that reply. Made a mistake in the browser.


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107470/#review22572
-----------------------------------------------------------


On Nov. 26, 2012, 10:36 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107470/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 10:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> On this patch i am replace the QRegExp on SigningDialog::validateParams() with KPIMUtils::isValidSimpleAddress
> 
> 
> Diffs
> -----
> 
>   plasmate/CMakeLists.txt 111c402 
>   plasmate/publisher/signingdialog.cpp 395138d 
> 
> Diff: http://git.reviewboard.kde.org/r/107470/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121126/4268bbe9/attachment.html>