Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

Jan Grulich grulja at gmail.com
Fri Nov 23 11:12:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107413/
-----------------------------------------------------------

(Updated Nov. 23, 2012, 11:12 a.m.)


Review request for kdelibs and Plasma.


Changes
-------

Wrong signal, accepted() actually works


Description
-------

Switch from QWeakPointer to staticaly created KNS3::DownloadDialog like in some KControl modules (i.e color scheme) to fix the problem when the list with widgets is not downloaded every time you open it.
Should fix this issue https://bugzilla.redhat.com/show_bug.cgi?id=877021


Diffs (updated)
-----

  plasma/private/packages.cpp 2519341 

Diff: http://git.reviewboard.kde.org/r/107413/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121123/b901ecaa/attachment.html>


More information about the Plasma-devel mailing list