Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

[Michael Zanetti]

> On Nov. 23, 2012, 1:03 p.m., Kai Uwe Broulik wrote:
> > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml, line 129
> > <http://git.reviewboard.kde.org/r/107428/diff/1/?file=95873#file95873line129>
> >
> >     Do two lines fit in? Maybe use
> >     elide: Text.ElideRight
> >     MaximumLineCount: 2

If I'm not completely blind the Plasma.Label does not support eliding, thats why I clipped instead.

No, how it is currently, 2 lines would trash the layout as the icons size is tied to the text height. I couldn't find anything reasonable to get a dynamic size but still having it looking the same it did before.


> On Nov. 23, 2012, 1:03 p.m., Kai Uwe Broulik wrote:
> > plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml, line 29
> > <http://git.reviewboard.kde.org/r/107428/diff/1/?file=95874#file95874line29>
> >
> >     Probably should get some maximum size (screen height, or 80% of screen height), it fills the entire screen here when I do 200 dpi

Hmm... It looks exactly how it should if I change my screen resolution to the half but keep the DPI settings of 200 (which should be exactly like your testing environment). Besides, if I attach it to the screen size it gets very long on 30 inch screens, while on small screens it clips all the text. Imho better making it adjust to the content it shows as long as it fits on the smallest possible screen.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107428/#review22425
-----------------------------------------------------------


On Nov. 23, 2012, 6:15 p.m., Michael Zanetti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107428/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 6:15 p.m.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Description
> -------
> 
> This adjustst the DeviceNotifier Plasmoid to scale nicely with high resolution screens.
> 
> The patch changes also one label from wordWrapping to clipping behavior because otherwise it messes up the layout.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml 1fab0ef 
>   plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml f8728d0 
> 
> Diff: http://git.reviewboard.kde.org/r/107428/diff/
> 
> 
> Testing
> -------
> 
> Tested on High res screen at full DPI and at regular DPI values
> 
> 
> Thanks,
> 
> Michael Zanetti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121123/47f462fe/attachment.html>