Review Request: plasmoid currentappconrol - max width of dropdown

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107433/#review22435
-----------------------------------------------------------



plasma/netbook/applets/currentappcontrol/currentappcontrol.cpp
<http://git.reviewboard.kde.org/r/107433/#comment17194>

    this assumes the containment is full width. this is probably true at all times for the netbook shell as it currently is. however, i'd probably do something like:
    
    containment()->corona()->screenGeometry(containment->screen()).width()
    
    oh, and maxwidth can be const :)


- Aaron J. Seigo


On Nov. 23, 2012, 10:27 a.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107433/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 10:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> the drop down list gets too wide (see screenshot), when the window titles are too long or the horizontal space is very small.
> In the patch I've elided the text width to ~80% of the screen width. Or is there a more natural solution?
> 
> 
> Diffs
> -----
> 
>   plasma/netbook/applets/currentappcontrol/currentappcontrol.cpp 5c2e73f9d6b8207efd3a3de6464278d1bdbc9263 
> 
> Diff: http://git.reviewboard.kde.org/r/107433/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> dropdown
>   http://git.reviewboard.kde.org/r/107433/s/850/
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121123/ef7e63f2/attachment-0001.html>