Review Request: Plasmate: Make Publisher able to remove the packages which have been installed with the cmake method

Antonis Tsiapaliokas kok3rs at gmail.com
Fri Nov 23 09:14:24 UTC 2012



> On Nov. 23, 2012, 12:06 a.m., Aaron J. Seigo wrote:
> > why would "Publish" do the exact opposite and uninstall something? shouldn't this be a different function? in which case is it needed / desired to even do this from plasmate?

Yes, you have right. The "Publish" should only install things..
So since plasmate is a tool for developers, should we leave plasmate without an uninstall feature? 


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107425/#review22407
-----------------------------------------------------------


On Nov. 22, 2012, 8:02 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107425/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2012, 8:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> With this patch the publisher is able to remove the packages which have been installed with the cmake method.
> 
> UI changes:
> *add a new entry to the comboBox with name "CMake Remove Installed Package"
> *When the current comboBox is the "CMake Remove Installed Package", then the text of installButton is changed.
> *the text of the installButtons becomes "Remove Package"
> 
> 
> Diffs
> -----
> 
>   plasmate/publisher/publisher.h ebb289e 
>   plasmate/publisher/publisher.cpp 60d18b9 
> 
> Diff: http://git.reviewboard.kde.org/r/107425/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121123/bf89a25e/attachment.html>


More information about the Plasma-devel mailing list