Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107413/#review22406
-----------------------------------------------------------



plasma/private/packages.cpp
<http://git.reviewboard.kde.org/r/107413/#comment17179>

    the real solution here is if the dialog exists, cause it to re-fetch the contents. if necessary (i have no idea how much the KNS3::DownloadDialog sucks in this area) delete it if it is not visible (implying it's been dismissed) and recreate it.
    
    or perhaps connect the finished() signal of the dialog to deleteLater(), which will cause it to be recreated after it's gone.
    


- Aaron J. Seigo


On Nov. 22, 2012, 7:08 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107413/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2012, 7:08 p.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> -------
> 
> Switch from QWeakPointer to staticaly created KNS3::DownloadDialog like in some KControl modules (i.e color scheme) to fix the problem when the list with widgets is not downloaded every time you open it.
> Should fix this issue https://bugzilla.redhat.com/show_bug.cgi?id=877021
> 
> 
> Diffs
> -----
> 
>   plasma/private/packages.cpp 2519341 
>   plasma/private/packages_p.h 15fde41 
> 
> Diff: http://git.reviewboard.kde.org/r/107413/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121123/5c4b5508/attachment.html>