Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

Kai Uwe Broulik kde at privat.broulik.de
Wed Nov 21 19:07:48 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107398/#review22339
-----------------------------------------------------------


But why does the battery plasmoid always set the old brightness? Now it knows the current brightness and sets it itself to the right value but still aren't these calls not needed and thus a bug also in the plasmoid?

- Kai Uwe Broulik


On Nov. 21, 2012, 5:43 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107398/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 5:43 p.m.)
> 
> 
> Review request for Plasma, Dario Freddi and Lukáš Tinkl.
> 
> 
> Description
> -------
> 
> the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal when you change the brightness without the brightnessKeys. I've just moved the signal to the setBrightness function. Now the powermanagement/PowerDevil dataengine gets also updated properly with the current brightness (this fixes the bugs).
> 
> 
> This addresses bugs 302111 and 302160.
>     http://bugs.kde.org/show_bug.cgi?id=302111
>     http://bugs.kde.org/show_bug.cgi?id=302160
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 
> 
> Diff: http://git.reviewboard.kde.org/r/107398/diff/
> 
> 
> Testing
> -------
> 
> works on my laptop when I set the screen brightness with the batterymonitor plasmoid
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121121/c000a1af/attachment-0001.html>


More information about the Plasma-devel mailing list