Review Request: Remove unneeded code

Marco Martin notmart at gmail.com
Fri Nov 16 13:01:43 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107342/#review22082
-----------------------------------------------------------

Ship it!


should be fine, that functions are probably a residual of when it was a qabstractitemmodel

- Marco Martin


On Nov. 16, 2012, 12:53 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107342/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2012, 12:53 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> AFAIK, this code is not doing much, so it can be removed.
> 
> 
> Diffs
> -----
> 
>   lib/bodega/installjobsmodel.h b5452d4 
>   lib/bodega/installjobsmodel.cpp f69ba16 
> 
> Diff: http://git.reviewboard.kde.org/r/107342/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121116/7a698dff/attachment.html>


More information about the Plasma-devel mailing list