Review Request: Plasmate: Fix typo on remoteinstaller.ui and give more sane names to labels.
Aaron J. Seigo
aseigo at kde.org
Wed Nov 14 11:53:14 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107312/#review21977
-----------------------------------------------------------
Ship it!
Ship It!
- Aaron J. Seigo
On Nov. 13, 2012, 6:20 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107312/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2012, 6:20 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch is changing the
>
> "Choose the source directory of your package.Your URL must end in a metadata.desktop file." => "Choose the source directory of your package."
>
> Because the remoteinstaller doesn't need the metadata.desktop but it needs the directory in which the metadata.dekstop is located.
>
> Also i have change the names of the labels of the remoteinsteller.ui, in order to be more pretty.
>
>
> Diffs
> -----
>
> plasmate/publisher/remoteinstaller/remoteinstaller.cpp 68bb7e3
> plasmate/publisher/remoteinstaller/remoteinstaller.ui ba9b0a3
> plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp aed72db
> plasmate/publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp 68554d4
>
> Diff: http://git.reviewboard.kde.org/r/107312/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121114/f51bff20/attachment.html>
More information about the Plasma-devel
mailing list