Review Request: Rework of metadatamusic qml components.

Aaron J. Seigo aseigo at kde.org
Tue Nov 13 14:58:01 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107299/#review21932
-----------------------------------------------------------


i assume someone give this approval on irc so it was committed, but in future, please have the person who peer reviews the patch mark the review with "ShipIt!" so that we know it has actually seen peer review. thanks :)

- Aaron J. Seigo


On Nov. 13, 2012, 11:11 a.m., Fabian Riethmayer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107299/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2012, 11:11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Rework of metadatamusic qml components.
> Switched album and artist view to gridview.
> 
> Refactored MediaItemDelegate.qml and created new MediaItem.qml
> 
> 
> Diffs
> -----
> 
>   browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml 5218866 
> 
> Diff: http://git.reviewboard.kde.org/r/107299/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Artist view
>   http://git.reviewboard.kde.org/r/107299/s/827/
> Track view
>   http://git.reviewboard.kde.org/r/107299/s/828/
> 
> 
> Thanks,
> 
> Fabian Riethmayer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121113/1f7b1df3/attachment-0001.html>


More information about the Plasma-devel mailing list