Review Request: Plasmate: The publisher can now return the error of the cmake. Publisher no longer need the $KDEDIRS

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107278/#review21815
-----------------------------------------------------------



plasmate/publisher/publisher.cpp
<http://git.reviewboard.kde.org/r/107278/#comment16840>

    includes may not be installed; better to search for bin or lib



plasmate/publisher/publisher.cpp
<http://git.reviewboard.kde.org/r/107278/#comment16841>

    missing spaces between "if" and "("



plasmate/publisher/publisher.cpp
<http://git.reviewboard.kde.org/r/107278/#comment16842>

    consider using a KMessageWidget here as well?



plasmate/publisher/publisher.cpp
<http://git.reviewboard.kde.org/r/107278/#comment16843>

    KMessageWidget?


- Aaron J. Seigo


On Nov. 10, 2012, 5:06 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107278/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 5:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch introduce following UI changes to the Publisher.
> 
> *If the cmake and make fails, then it returns an error
> *If the cmake and make are successful, then it says that the plasmoid has been installed.
> 
> 
> Diffs
> -----
> 
>   plasmate/publisher/publisher.h b9b26ba 
>   plasmate/publisher/publisher.cpp 9575d07 
> 
> Diff: http://git.reviewboard.kde.org/r/107278/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121111/a9c62552/attachment.html>