Review Request: Reduce verbosity when running a QML-based plasmoid

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107261/#review21678
-----------------------------------------------------------

Ship it!


cool, that was on my todo list since loooong time :)

- Marco Martin


On Nov. 9, 2012, 1:27 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107261/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 1:27 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Right now, every QML plasmoid can provide a number of properties (6, actually) to specify some size hints (maximum, minimum and preferred).
> 
> If you don't provide those properties you get many warnings because of the missing changed connections. This patch removes such  warnings by making sure the property is present before connecting and querying the property at all.
> 
> I'd suggest that in case we want notifications for the lack of those properties, this should be in the plasmoidviewer or such. Today I was trying to debug an issue while loading the qml wallpapers when loading plasma-desktop and I was flooded by those.
> 
> 
> Diffs
> -----
> 
>   plasma/widgets/declarativewidget.cpp 3176073 
> 
> Diff: http://git.reviewboard.kde.org/r/107261/diff/
> 
> 
> Testing
> -------
> 
> I ran org.kde.graphsplasmoid before patching and I got many warnings. After patching I didn't get those.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121109/83738a39/attachment.html>