Review Request: Port the Calculator applet to QML

[Romário Rios]

> On Nov. 8, 2012, 9:33 a.m., Marco Martin wrote:
> > style is quite ok to me now.
> > functions could still be changed to
> > 
> > function foo()
> > {
> > ...
> > }
> 
> Aaron J. Seigo wrote:
>     actually, the style was finally updated to:
>     
>     function foo() {
>     }
>     
>     so no need to adjust this :)
> 
> Marco Martin wrote:
>     aand ignore last comment, style guidelines ended up being
>     function foo () {
>       ..
>     }
>     
>     inthe end. so the current code is ok

Then, as the hard freeze is scheduled for today, I'm gonna merge this later tonight if noone objects.


- Romário


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/#review21614
-----------------------------------------------------------


On Nov. 6, 2012, 11:36 p.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107001/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 11:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 732145c 
>   calculator.h f7339be 
>   calculator.cpp 6bc3ddc 
>   package/contents/ui/calculator.qml PRE-CREATION 
>   package/metadata.desktop PRE-CREATION 
>   plasma-applet-calculator.desktop 0760729 
> 
> Diff: http://git.reviewboard.kde.org/r/107001/diff/
> 
> 
> Testing
> -------
> 
> Tested as both applet and popupapplet, with the Air theme and the Oxygen theme. It seems to work fine.
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121108/cd694e78/attachment.html>