Review Request: ToolBox bindings for declarative containments

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107232/
-----------------------------------------------------------

(Updated Nov. 7, 2012, 2:40 p.m.)


Review request for Plasma.


Changes
-------

Changes as proposed by Marco.


Description
-------

ToolBox bindings for declarative containments

This adds the necessary bits, actions handling, showing / hiding of toolbox and a hooks for config interface and add widgets.


The interesting bits:

Toolbox separate on the scene
For declarative containments, we add a declarativewidget on top of the view which loads the "org.kde.toolbox" package. The toolbox can differ per platform, layout of toolbox and containment can not "leak" into each other.

ToolBox import
The most important and interesting bit is the list of actions the ToolBox exposes, it's collected from corona, containment. The latter is actually problematic, since we don't get access to the actions internally provided by Containment (ContainmentPrivate::addDefaultActions). Containment::setToolBox(AbstractToolBox) being protected, we cannot register our declarative ToolBoxProxy implementation to the containment, so we have to wire up settings and addwidgets separately. Sorting of the actions is "random", and expected to be done by the QML toolbox implementation, based on objectName strings.


Diffs (updated)
-----

  plasma/scriptengines/javascript/CMakeLists.txt fe06582 
  plasma/scriptengines/javascript/declarative/toolboxproxy.h PRE-CREATION 
  plasma/scriptengines/javascript/declarative/toolboxproxy.cpp PRE-CREATION 
  plasma/scriptengines/javascript/plasmoid/appletinterface.h 6fc2d74 
  plasma/scriptengines/javascript/plasmoid/appletinterface.cpp ed5c8ae 
  plasma/scriptengines/javascript/plasmoid/declarativeappletscript.h 57689ba 
  plasma/scriptengines/javascript/plasmoid/declarativeappletscript.cpp 4caceb0 

Diff: http://git.reviewboard.kde.org/r/107232/diff/


Testing
-------

Using this with QML Desktop Containment, works as advertised above.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121107/6362ab7f/attachment.html>