Review Request: Plasmate: Remove Python support for konsole previewer

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107209/#review21444
-----------------------------------------------------------



plasmate/mainwindow.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16671>

    typo, cleat -> clear
    
    The comment can probably go away anyway, code looks pretty clear right there.



plasmate/previewer/plasmoid/previewcontainment.h
<http://git.reviewboard.kde.org/r/107209/#comment16676>

    add the bool visible also here



plasmate/previewer/plasmoid/previewcontainment.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16677>

    bool visible



plasmate/previewer/plasmoid/previewcontainment.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16674>

    --debug :)



plasmate/previewer/plasmoid/previewcontainment.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16679>

    Can't we use Plasma::Package here? The finding of the metadata.desktop file is a bit clumsy as it relies on package internals.



plasmate/previewer/plasmoid/previewcontainment.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16673>

    doesn't -> don't, comma after kDebug



plasmate/previewer/plasmoid/previewcontainment.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16672>

    -are



plasmate/previewer/plasmoid/previewcontainment.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16680>

    We need to be damn sure that this is the right item...



plasmate/previewer/previewer.h
<http://git.reviewboard.kde.org/r/107209/#comment16675>

    virtual void setKonsolePreviewer(bool visible = true);
    
    so it can be toggled



plasmate/previewer/previewer.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16678>

    bool visible


- Sebastian Kügler


On Nov. 5, 2012, 2:25 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107209/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 2:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Right now the python bindings doesn't support the kDebug, so the konsole previewer cannot return any output.
> Until this is fixed, we are disabling the python support for the konsole previewer.
> 
> 
> Diffs
> -----
> 
>   plasmate/mainwindow.h 6ac6fcd 
>   plasmate/mainwindow.cpp 9c19658 
>   plasmate/previewer/plasmoid/previewcontainment.h 34dfb52 
>   plasmate/previewer/plasmoid/previewcontainment.cpp 266baa4 
>   plasmate/previewer/previewer.h 271bab8 
>   plasmate/previewer/previewer.cpp 6f07098 
> 
> Diff: http://git.reviewboard.kde.org/r/107209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121105/552e80a3/attachment-0001.html>