Review Request: digital clock widget - popup focus

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105933/#review21437
-----------------------------------------------------------


This is not a bug, but a feature. :)

The calendar, as opposed to most other widgets, is often used alongside other windows for reference. Say for example you're chatting with someone about an appointment, and want to peak at the calendar while discussing possible dates. If the calendar closed on losing focus, it would be highly annoying. We made a design decision that the use cases for the calendar are different enough to warrant the inconsistency in behaviour, that is why the popup of the calendar doesn't close, while others do -- they're used differently.

Sorry that the review request was lingering that long. I've also posted this comment as reply to the bugreport.

- Sebastian Kügler


On Aug. 20, 2012, 6:07 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105933/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2012, 6:07 p.m.)
> 
> 
> Review request for Plasma and John Layt.
> 
> 
> Description
> -------
> 
> For some reason for this widgt the option setPassivePopup is enabled (probably because you can't control it with keyboard anyways). Interestingly, the result is that the popup doesn't hide if you, for example, open the settings dialog. This behaviour is a bug and not consistent with all other popup widgets.
> 
> I suppose this fixes also https://bugs.kde.org/show_bug.cgi?id=221301
> 
> On the other hand, we could also try to fix that passive popup feature, if it's broken...I don't know.
> 
> 
> This addresses bug 221301.
>     http://bugs.kde.org/show_bug.cgi?id=221301
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/clock.cpp 1331776 
> 
> Diff: http://git.reviewboard.kde.org/r/105933/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121105/63ac1a54/attachment.html>