Review Request: Fix bold text in battery-monitor tooltip

Sebastian Kügler sebas at kde.org
Mon Nov 5 10:38:33 UTC 2012



> On Nov. 2, 2012, 11:18 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/code/logic.js, line 68
> > <http://git.reviewboard.kde.org/r/107173/diff/1/?file=93189#file93189line68>
> >
> >     The first agument is a comment for the translators. It won't need to be bold.
> 
> Michele Gastaldo wrote:
>     Ops, I had no idea..thanks, now it's fixed!
>     
>     I'm not sure of the procedure afterwards...supposing it's enough with 2 reviews, who should ship it?

If you don't have git commit access, I can commit it for you.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107173/#review21345
-----------------------------------------------------------


On Nov. 3, 2012, 5:23 p.m., Michele Gastaldo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107173/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2012, 5:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Makes usage of bold text in the tooltip consistent with the widget. 
> 
> 
> This addresses bug 306903.
>     http://bugs.kde.org/show_bug.cgi?id=306903
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/contents/code/logic.js b5c0d21 
> 
> Diff: http://git.reviewboard.kde.org/r/107173/diff/
> 
> 
> Testing
> -------
> 
> Patch tried in real system, all messages are displayed correctly at the right moment
> 
> 
> Thanks,
> 
> Michele Gastaldo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121105/779b6874/attachment.html>


More information about the Plasma-devel mailing list