Review Request: porting comic plasmoid to qml
Reza Shah
rshah0385 at kireihana.com
Sun Nov 4 07:15:11 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107192/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
This patch is an attempt to port some part of comic plasmoid to QML.
Most of the ported part are related to UI.
The comic fetching logic are still in C++.
In this patch, some features which related to changing applet size are removed.
There are also some feature not finished:
- ability to set content position based on reading direction option in comic(top to bottom or left to right)
- tooltip to display additional text(the code is exist but still have problem).
You can also try from rshah/comicqml branch.
Diffs
-----
applets/comic/CMakeLists.txt 91fa29f
applets/comic/activecomicmodel.h PRE-CREATION
applets/comic/activecomicmodel.cpp PRE-CREATION
applets/comic/appearanceSettings.ui a153bf2
applets/comic/arrowwidget.h 64b1b36
applets/comic/arrowwidget.cpp 72d48ed
applets/comic/buttonbar.h d4020bb
applets/comic/buttonbar.cpp bb4dbef
applets/comic/comic.h f5919df
applets/comic/comic.cpp 3753eac
applets/comic/comicwidgets.h 4320c58
applets/comic/configwidget.h e9d63c8
applets/comic/configwidget.cpp baddd45
applets/comic/fullviewwidget.h c0a1aff
applets/comic/fullviewwidget.cpp fc78ba6
applets/comic/imagewidget.h 0825cfc
applets/comic/imagewidget.cpp 9d36034
applets/comic/package/contents/ui/ButtonBar.qml PRE-CREATION
applets/comic/package/contents/ui/ComicBottomInfo.qml PRE-CREATION
applets/comic/package/contents/ui/ComicCentralView.qml PRE-CREATION
applets/comic/package/contents/ui/FullViewWidget.qml PRE-CREATION
applets/comic/package/contents/ui/ImageWidget.qml PRE-CREATION
applets/comic/package/contents/ui/main.qml PRE-CREATION
applets/comic/package/metadata.desktop PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107192/diff/
Testing
-------
Tested the applet from my branch with other environment from master, seems working fine.
There might be some missing features.
Thanks,
Reza Shah
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121104/b20e506a/attachment.html>
More information about the Plasma-devel
mailing list