Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed
Dmitry Ashkadov
dmitry.ashkadov at rosalab.ru
Fri Nov 2 12:40:57 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107160/
-----------------------------------------------------------
(Updated Nov. 2, 2012, 12:40 p.m.)
Review request for Plasma, Aaron J. Seigo and Marco Martin.
Changes
-------
I've made last 2 commits in another way described by Aaron. So, new diff and new branch plasma/dmitrya/systemtray-refactoring-2.
Description
-------
Aaron has noticed in his mail to plasma-devel that the system tray requires some refactoring. This is a first step of refactoring. If it is approved I'll continue work on system tray.
Diffs (updated)
-----
plasma/generic/applets/systemtray/CMakeLists.txt d3478a8
plasma/generic/applets/systemtray/core/task.h 66bf6e1
plasma/generic/applets/systemtray/core/task.cpp 8754785
plasma/generic/applets/systemtray/package/contents/code/main.js 10518cd
plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml f251cc5
plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml 27d476a
plasma/generic/applets/systemtray/package/contents/ui/main.qml f80abc7
plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 34aae74
plasma/generic/applets/systemtray/protocols/fdo/fdotask.h 85a9ec5
plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.h 1913986
plasma/generic/applets/systemtray/ui/applet.h bab8d9c
plasma/generic/applets/systemtray/ui/applet.cpp 41efb10
plasma/generic/applets/systemtray/ui/mouseredirectarea.h 91c40c0
plasma/generic/applets/systemtray/ui/mouseredirectarea.cpp aac2a53
plasma/generic/applets/systemtray/ui/plasmoid.h 01a7c5b
plasma/generic/applets/systemtray/ui/plasmoid.cpp d3e1937
plasma/generic/applets/systemtray/ui/taskspool.h 4b5bcd4
plasma/generic/applets/systemtray/ui/taskspool.cpp df39e3d
plasma/generic/applets/systemtray/ui/uitask.h 7b20bde
plasma/generic/applets/systemtray/ui/uitask.cpp 2a15800
plasma/generic/applets/systemtray/ui/widgetitem.h 40aa92d
plasma/generic/applets/systemtray/ui/widgetitem.cpp 9d2c622
Diff: http://git.reviewboard.kde.org/r/107160/diff/
Testing
-------
Thanks,
Dmitry Ashkadov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121102/c7ecd07e/attachment.html>
More information about the Plasma-devel
mailing list