Review Request: Fix bold text in battery-monitor tooltip

Sebastian Kügler sebas at kde.org
Fri Nov 2 11:18:07 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107173/#review21345
-----------------------------------------------------------

Ship it!


One small comment, otherwise good to go. Good catch!


plasma/generic/applets/batterymonitor/contents/code/logic.js
<http://git.reviewboard.kde.org/r/107173/#comment16614>

    The first agument is a comment for the translators. It won't need to be bold.


- Sebastian Kügler


On Nov. 1, 2012, 10:26 p.m., Michele Gastaldo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107173/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2012, 10:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Makes usage of bold text in the tooltip consistent with the widget. 
> 
> 
> This addresses bug 306903.
>     http://bugs.kde.org/show_bug.cgi?id=306903
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/contents/code/logic.js b5c0d21 
> 
> Diff: http://git.reviewboard.kde.org/r/107173/diff/
> 
> 
> Testing
> -------
> 
> Patch tried in real system, all messages are displayed correctly at the right moment
> 
> 
> Thanks,
> 
> Michele Gastaldo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121102/4845c019/attachment.html>


More information about the Plasma-devel mailing list