Review Request: load the images for the themes correctly

Giorgos Tsiapaliokas terietor at gmail.com
Fri Nov 2 08:46:30 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106680/
-----------------------------------------------------------

(Updated Nov. 2, 2012, 8:46 a.m.)


Review request for Plasma.


Changes
-------

yesterday in irc, we searched the issue(me and Aaron)
and Aaron found out that this isn't a bug in libplasma but in plasmate's packagemodel.
Indeed plasmate's packagemodel was using PackageStructure::path(which is deprecated) instead
of PackageStructure::searchPath.

the issues are solved :)


Description
-------

create a new theme package->click on the new

a file dialog should appear but instead a simple edit box appears requesting a new filename.

This patch solves the issue


Diffs (updated)
-----

  plasmate/editors/editpage.h 5cb3ea6 
  plasmate/editors/editpage.cpp 7e82ff2 
  plasmate/packagemodel.cpp 9eb0914 

Diff: http://git.reviewboard.kde.org/r/106680/diff/


Testing
-------


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121102/3fbb2c9b/attachment.html>


More information about the Plasma-devel mailing list