Review Request: load the images for the themes correctly

Giorgos Tsiapaliokas terietor at gmail.com
Thu Nov 1 15:08:05 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106680/
-----------------------------------------------------------

(Updated Nov. 1, 2012, 3:08 p.m.)


Review request for Plasma.


Changes
-------

I have fixed the above issues.

There is one more issue, plasmate doesn't add a the description for the *svgz files.
I have searched the issue and I noticed that issue comes from kdelibs/plasma/private/packages.cpp
If two files have the same key in Plasma::Package::addFileDefinition then only the first one will have a description,
but if their keys aren't the same then both of them can have a description.

Modified they key for the svgz files, is a good solution to our problem?(of course in another review)


Description
-------

create a new theme package->click on the new

a file dialog should appear but instead a simple edit box appears requesting a new filename.

This patch solves the issue


Diffs (updated)
-----

  plasmate/editors/editpage.h 5cb3ea6 
  plasmate/editors/editpage.cpp 7e82ff2 
  plasmate/packagemodel.cpp 9eb0914 

Diff: http://git.reviewboard.kde.org/r/106680/diff/


Testing
-------


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121101/3189df47/attachment-0001.html>


More information about the Plasma-devel mailing list