Review Request: Add Package bindings from MobileComponents to PlasmaCore

[Aaron J. Seigo]

> On Nov. 1, 2012, 9:58 a.m., Aaron J. Seigo wrote:
> > the reason this is still in MobileComponent is because it isn't quite "general purpose use" ready. the biggest issue is that it always assumes a Plasma/Generic type and can not load from anywhere other than the normal system install paths.
> > 
> > properties for type and install root would probably fix that. with those properties, the package should not be created on setting the name, but when there is at least both package name and type. this could be problematic as to avoid creating packages and metadata types repeatedly, it should probably be done in a delayed fashion e.g. with a timer that is started whenever the properties change. a concern there then is that filePath will not return anything until that happens, so that also may not be workable.
> > 
> > it may even make sense to create the package in the filePath methods?
> > 
> > Marco probably has though this through a lot more as well .. 
> > 
> > also, a bool valid read-only property should be added.
> 
> Marco Martin wrote:
>     yes, the problem of it is that it can only access packages of generic type in the default system wide default directory.
>     
>     now, it *may* make sense to make this more generic, *but* it may have quite serious counterindications:
>     imageine a plasmoid using that to access files belonging to a package of another plasmoid.... not sure i want to go there.

even right now, even with generic packages, all sorts of files can be fetched: org.kde.active.launcher, org.kde.activityswitcher, org.kde.active.widgetsexplorer, etc.

the security / cleanliness aspect of this is not opened up by making this component more generic: it already exists. what we need is a definition of what is ok to access when/where. we should probably take this discussion to the mailing list, but i don't think it impacts moving Package to PlasmaCore.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107166/#review21281
-----------------------------------------------------------


On Nov. 1, 2012, 12:24 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107166/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2012, 12:24 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add Package bindings from MobileComponents
> 
> This adds bindings for Plasma::Package to the PlasmaCore plugin.
> 
> This class has moved and been renamed from plasma-mobile's
> MobileComponents (Package -> PackageProxy, runtime-visible, it's just
> PlasmaCore.Package).
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/CMakeLists.txt bf4625c588d13f00da9bd9f72f0eec60cb889616 
>   plasma/declarativeimports/core/corebindingsplugin.cpp 755dad61ceee070d50c7731e14f284b89c0f8d30 
>   plasma/declarativeimports/core/packageproxy.h PRE-CREATION 
>   plasma/declarativeimports/core/packageproxy.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107166/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121101/09b4a9fa/attachment.html>