Review Request: AppletContainer has moved to scriptengine

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107165/#review21292
-----------------------------------------------------------

Ship it!


+1 from here too

- Marco Martin


On Oct. 31, 2012, 11:22 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107165/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2012, 11:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> * remove AppletContainer from MobileComponents
> * Port all uses of AppletContainer to org.kde.plasma.containments
> 
> This class has been moved into the scriptengine in kde-runtime (master), and is
> available for all containments as type.
> 
> My branch splits this up into two commits (one for the mobilecomponents and one for the porting), I've put it into one review request since their both closely related (and fairly trivial).
> 
> 
> Diffs
> -----
> 
>   components/mobilecomponents/CMakeLists.txt 981843c4be970c5aef450ef4cdc6721162f950c3 
>   components/mobilecomponents/appletcontainer.h 76587f2ca6131c228f70677b8c5f989039b3f4f6 
>   components/mobilecomponents/appletcontainer.cpp 2dc54092033e8d07737a2b31e006f8211137e48a 
>   components/mobilecomponents/mobilecomponentsplugin.cpp 6a63631413a2508ba547c2402803a45d07bb4d4a 
>   containments/activityscreen/contents/ui/PlasmoidGroup.qml b394bc03f73c84d58aefd3a91ef4999f9703615a 
>   containments/appletstrip/contents/ui/PlasmoidContainer.qml 70226dae7caf55c0d163490ee7b5375bda882ce6 
>   containments/systemtray/contents/ui/PlasmoidContainer.qml 270c4fcd5085a9236b48609caa03c98fa24fc453 
> 
> Diff: http://git.reviewboard.kde.org/r/107165/diff/
> 
> 
> Testing
> -------
> 
> Tested actity screen and system tray in plasma-device and plasma-desktop and plasmoidviewer, no errors.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121101/d26c09ef/attachment.html>