Review Request: kickoff: save recent applications list on every change to it

[Trever Fischer]

On Thu, 2012-05-31 at 16:45 +0200, Mark wrote:
> On Thu, May 31, 2012 at 3:36 PM, Trever Fischer
> <tdfischer at fedoraproject.org> wrote:
>         This is an automatically generated e-mail. To reply, visit:
>         http://git.reviewboard.kde.org/r/105112/ 
>         
>         
>                 On May 31st, 2012, 10:09 a.m., Aaron J. Seigo wrote:
>                 
>                         the real fubar here is that it stores this information internally in its own config file. this really ought to be stored/retrieved from nepomuk and/or zeitgeist.
>                         
>                         i've cc'd Trever on this because he may have something to say about that as well.
>         I actually just recently patched Dragon to do so, and it took very few lines: http://quickgit.kde.org/index.php?p=dragon.git&a=commitdiff&h=92fb6296e424dc829e0c5cc541aa3581856d2098
>         
>         Since Kickoff uses QAbstractItemModels, switching things to use a QZeitgeist::LogModel should be trivial. Alternatively, implementing the RecentApplications class to use Zeitgeist can be trivial as well, and would seem like the easiest way to do things.
>         
>         
>         
>         - Trever
>         
>         
>         On May 31st, 2012, 10:08 a.m., Andriy Gapon wrote:
>         
>         Review request for Plasma and Trever Fischer.
>         By Andriy Gapon.
>         Updated May 31, 2012, 10:08 a.m.
>         
>         
>         Description 
>         Currently recent applications list in kickoff is saved only when kickoff gracefully exits.  This could be a minor annoyance when X/KDE/plasma crashes.  I think that saving the list on every update to it should be a good idea.  It should be a low overhead too, because the list changes only when a user launches an application via KDE.
>         Bugs: 206511
>         Diffs 
>               * plasma/desktop/applets/kickoff/core/recentapplications.cpp (3e05389)
>         
>         View Diff
>         
>         
>         
>         _______________________________________________
>         Plasma-devel mailing list
>         Plasma-devel at kde.org
>         https://mail.kde.org/mailman/listinfo/plasma-devel
>         
> 
> This is a bit off topic for the review thus responding by mail.
> 
> 
> When i read the title i immediately thought: "ZEITGEIST!" ;)
> Anyhow, i'd like to know a little thingy about the RecentApplications
> class. Is that class being called for every application that gets
> started or only for applications that get started through kickoff?
> (i'm betting the latter one is the case though i could be wrong..)
> 
> 
> Assuming it's the latter one, is there any place in KDE where every
> single application passes through when it gets started? Since that
> would be the perfect place to add zeitgeist support! Then just let
> Kickoff read the recently used applications from zeitgeist.

I believe that is krunner. I'm looking at that today, trying to
determine if its possible to stick it in krunner, or if we need to stick
it in the KToolInvocation class. Depends on what the event's actor
property needs set to.

Once that is in place I can have some useful data and patch kickoff to
display the information.

> 
> 
> Just a random idea :)
> 
> 
> Cheers,
> Mark