Review Request: kickoff: save recent applications list on every change to it

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105112/#review14293
-----------------------------------------------------------


the real fubar here is that it stores this information internally in its own config file. this really ought to be stored/retrieved from nepomuk and/or zeitgeist.

i've cc'd Trever on this because he may have something to say about that as well.


plasma/desktop/applets/kickoff/core/recentapplications.cpp
<http://git.reviewboard.kde.org/r/105112/#comment11307>

    holding on to groups like this is a bit dangerous; you need to be able to know that the kconfig object behind it is always valid at all times. better to just create the group when needed.
    
    a method that returns such a group on demand lets the code be shared, avoiding duplication of magic strings. e.g.:
    
    KConfigGroup config()
    {
        return componentData().config()->group("RecentlyUsed");
    }



plasma/desktop/applets/kickoff/core/recentapplications.cpp
<http://git.reviewboard.kde.org/r/105112/#comment11308>

    it pains me to see such calls in paths which could be called quite often. yes, in theory should only happen when apps launch, but there is no guarantee that this will remain that way or that such events will not happen in rapid bursts.


- Aaron J. Seigo


On May 31, 2012, 10:08 a.m., Andriy Gapon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105112/
> -----------------------------------------------------------
> 
> (Updated May 31, 2012, 10:08 a.m.)
> 
> 
> Review request for Plasma and Trever Fischer.
> 
> 
> Description
> -------
> 
> Currently recent applications list in kickoff is saved only when kickoff gracefully exits.  This could be a minor annoyance when X/KDE/plasma crashes.  I think that saving the list on every update to it should be a good idea.  It should be a low overhead too, because the list changes only when a user launches an application via KDE.
> 
> 
> This addresses bug 206511.
>     http://bugs.kde.org/show_bug.cgi?id=206511
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e05389 
> 
> Diff: http://git.reviewboard.kde.org/r/105112/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andriy Gapon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120531/7894a012/attachment.html>