Review Request: fix callback race in the session saving and shutdown code

[Andriy Gapon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105111/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

This patch tries to a fix a race in the session saving and shutdown code of ksmserver.
The race may happen on wmPhase1WaitingCount variable when WM-type clients are fast enough to complete their save requests while the loop in KSMServer::shutdown is still iterating.  As a result wmPhase1WaitingCount may become zero too early and that would kick off the next save/shutdown phase in a client's callback.  In fact, it might even go multiple times from zero to non-zero and back during the WM-specific loop.


This addresses bug 206511.
    http://bugs.kde.org/show_bug.cgi?id=206511


Diffs
-----

  ksmserver/shutdown.cpp a5a1ef9 

Diff: http://git.reviewboard.kde.org/r/105111/diff/


Testing
-------


Thanks,

Andriy Gapon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120531/2211c31b/attachment.html>